[BUG][AQE][LocalOrder] Fix the bug of missed data due to block sorting#347
Merged
zuston merged 1 commit intoapache:masterfrom Nov 22, 2022
Merged
[BUG][AQE][LocalOrder] Fix the bug of missed data due to block sorting#347zuston merged 1 commit intoapache:masterfrom
zuston merged 1 commit intoapache:masterfrom
Conversation
Member
Author
|
PTAL @jerqi |
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
============================================
+ Coverage 58.39% 58.42% +0.02%
- Complexity 1552 1554 +2
============================================
Files 193 193
Lines 10761 10763 +2
Branches 937 937
============================================
+ Hits 6284 6288 +4
+ Misses 4103 4102 -1
+ Partials 374 373 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
Author
|
Merged. Thanks @jerqi for catching this bug. |
Contributor
|
@zuston Could you see the flaky test https://github.com/apache/incubator-uniffle/actions/runs/3524774587/jobs/5910627949? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Fix the bug of missed data due to block sorting
Does this PR introduce any user-facing change?
No
How was this patch tested?